Updated MessagePanelHandler pull request#2
Open
dieterichlawson wants to merge 2 commits intofrontlinesms:masterfrom
dieterichlawson:master
Open
Updated MessagePanelHandler pull request#2dieterichlawson wants to merge 2 commits intofrontlinesms:masterfrom dieterichlawson:master
dieterichlawson wants to merge 2 commits intofrontlinesms:masterfrom
dieterichlawson:master
Conversation
shouldClearRecipientField is a boolean that indicates whether the recipient field of the message panel should be cleared after a message is sent.
- changed shouldClearRecipientField -> clearRecipientFieldOnSend - removed useless getter - added space after parameter definition of setter to conform to style guidelines
|
Should we merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alex - I made the changes you specified. The most recent commit has all the info.